Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection for patch release versions #3908

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix connection for patch release versions #3908

merged 1 commit into from
Apr 24, 2024

Conversation

haslinghuis
Copy link
Member

Currently it was not possible to connect with firmware 4.5.1 or above.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 24, 2024
@haslinghuis haslinghuis self-assigned this Apr 24, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 4e511da
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66294bf22b3ca90008c70dc7
😎 Deploy Preview https://deploy-preview-3908--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

built with fake 1.47.
results:
image

Maybe should say for example, does not support firmware 4.5.0 containing API version 1.47. This might clarify any confusion of the versioning.
the word containing could easily be with as well. Unsure the best terminology.
Otherwise, good to go.

@haslinghuis
Copy link
Member Author

@nerdCopter a fake build with 4.6 would look like:

FC.CONFIG.apiVersion = '1.47.0';
FC.CONFIG.flightControllerVersion = '4.6.0';

image

@haslinghuis haslinghuis merged commit befa88b into betaflight:master Apr 24, 2024
11 checks passed
@haslinghuis haslinghuis deleted the fix-connection-patch-version branch April 24, 2024 18:53
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix connection for patch release versions (betaflight#3908)
6350f2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HThuren HThuren HThuren approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@blckmn blckmn Awaiting requested review from blckmn

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@asizon asizon Awaiting requested review from asizon

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @nerdCopter @HThuren